Repository navigation
fix: load indirect shares in editors - #3313
Merged
JammingBen merged 2 commits intoSep 30, 2026
Merged
Conversation
fredrikblau
force-pushed
the
fix/3298-editor-indirect-shares
branch
from
September 5, 2026 13:10
9b73947 to
0249e75
Compare
JammingBen
requested changes
Sep 8, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
Thanks! One nitpick from my side, plus it needs a rebase.
fredrikblau
force-pushed
the
fix/3298-editor-indirect-shares
branch
from
September 8, 2026 09:06
0249e75 to
de75a68
Compare
JammingBen
force-pushed
the
fix/3298-editor-indirect-shares
branch
from
September 30, 2026 12:33
de75a68 to
4d21aa7
Compare
JammingBen
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Editor routes load files without the folder loader, so ancestor metadata stays empty. The sharing sidebar then has no ancestor IDs from which to load indirect shares.
Load ancestor metadata when the share loader runs inside an editor. The regression test covers both search and editor routes.
Related Issue
How Has This Been Tested?
Types of changes