Skip to content

fix: load indirect shares in editors - #3313

Merged
JammingBen merged 2 commits into
opencloud-eu:mainfrom
fredrikblau:fix/3298-editor-indirect-shares
Sep 30, 2026
Merged

JammingBen merged 2 commits into
opencloud-eu:mainfrom
fredrikblau:fix/3298-editor-indirect-shares

Conversation

@fredrikblau

@fredrikblau fredrikblau commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Editor routes load files without the folder loader, so ancestor metadata stays empty. The sharing sidebar then has no ancestor IDs from which to load indirect shares.

Load ancestor metadata when the share loader runs inside an editor. The regression test covers both search and editor routes.

Related Issue

How Has This Been Tested?

  • test environment: Node 24.20.0, pnpm 11.25.0
  • test case 1: FileSideBar unit suite (19 passed)
  • test case 2: full unit suite (3,916 passed, 6 skipped, 11 todo)
  • test case 3: type checks, lint, formatting, and production build

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@fredrikblau
fredrikblau force-pushed the fix/3298-editor-indirect-shares branch from 9b73947 to 0249e75 Compare September 5, 2026 13:10

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nitpick from my side, plus it needs a rebase.

Comment thread packages/web-pkg/src/composables/shares/useLoadShares.ts Outdated
@fredrikblau
fredrikblau force-pushed the fix/3298-editor-indirect-shares branch from 0249e75 to de75a68 Compare September 8, 2026 09:06
@JammingBen
JammingBen force-pushed the fix/3298-editor-indirect-shares branch from de75a68 to 4d21aa7 Compare September 30, 2026 12:33
@JammingBen
JammingBen merged commit 514074e into opencloud-eu:main Sep 30, 2026
32 checks passed
@openclouders openclouders mentioned this pull request Sep 30, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor doesn't show indirect shares in sidebar

2 participants